Eip4844 Point Evaluation precompile #2701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvacaru
reviewed
Feb 4, 2025
| @@ -2414,6 +2438,7 @@ The intrinsic gas calculation mirrors the style of the YellowPaper (appendix H). | |||
| rule <k> #gasExec(SCHED, ECMUL) => Gecmul < SCHED > ... </k> | |||
| rule <k> #gasExec(SCHED, ECPAIRING) => Gecpairconst < SCHED > +Int (lengthBytes(DATA) /Int 192) *Int Gecpaircoeff < SCHED > ... </k> <callData> DATA </callData> | |||
| rule <k> #gasExec(SCHED, BLAKE2F) => Gfround < SCHED > *Int #asWord(#range(DATA, 0, 4) ) ... </k> <callData> DATA </callData> | |||
| rule <k> #gasExec(_, KZGPOINTEVAL) => 50000 ... </k> | |||
There was a problem hiding this comment.
I think it would be better to use a schedule variable here,
Suggested change
| rule <k> #gasExec(_, KZGPOINTEVAL) => 50000 ... </k> | |
| rule <k> #gasExec(SCHED , KZGPOINTEVAL) => Gpointeval < SCHED > ... </k> |
Where Gpointeval would be defined in schedule.md as
rule Gpointeval < DEFAULT > => 0
rule Gpointeval < CANCUN > => 50000
This ensures that the 50000 value is preserved and can be updated dynamically in future hardforks without modifying this rule directly.
There was a problem hiding this comment.
Got it, I believe I addressed it.
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the point evaluation precompile for EIP-4844. It relies on this PR, that implements a new hook for
verify_kzg_proofin the blockchain-k-plugin.